render: Clean up unused code and duplicate consts#83
Open
adamwg wants to merge 2 commits into
Open
Conversation
As noted by the coderabbit bot on crossplane#82, this const is duplicated in the CLI. Use the version from crossplane-runtime, since it's what Crossplane uses. Signed-off-by: Adam Wolfe Gordon <[email protected]>
When we switched render to use the high-fidelity engine (`crossplane internal render`), we left behind some helper functions that are exported but no longer used. These functions just duplicate functionality from the real composite controller, so they shouldn't be necessary for any external consumers of the render code. Signed-off-by: Adam Wolfe Gordon <[email protected]>
|
Ready to act? Review this PR in Change Stack to turn feedback into patch suggestions you can inspect and refine. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (2)
📝 WalkthroughWalkthroughThis PR removes exported annotation constants and helper functions ( ChangesMetadata Helper Removal and Annotation Key Migration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (2 errors)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
The coderabbit bot noted on #82 that we're duplicating the
xcrd.AnnotationKeyCompositionResourceNameconst from crossplane-runtime. Thefirst commit in this PR removes this duplication.
While digging into the duplicate const, I noticed that we have a bunch of
duplicated consts, which led me to a couple of functions that are exported but
unused since we switched to
crossplane internal render. These functions justduplicate functionality from the real composite controller, so they shouldn't be
necessary for any external consumers of the render code.
I have:
./nix.sh flake checkto ensure this PR is ready for review.- [ ] Added or updated unit tests.- [ ] Linked a PR or a docs tracking issue to document this change.- [ ] Addedbackport release-x.ylabels to auto-backport this PR.